Changeset 3096 for DataCleaner

Timestamp:

01/27/12 12:21:07 (4 months ago)

Author:

kasper

Message:

Added validation of excel spread sheet names.

Location:

DataCleaner/trunk

Files:

• core/src/main/java/org/eobjects/datacleaner/output/beans/CreateExcelSpreadsheetAnalyzer.java (modified) (2 diffs)
• core/src/main/java/org/eobjects/datacleaner/widgets/properties/PropertyWidgetFactory.java (modified) (1 diff)
• core/src/test/java/org/eobjects/datacleaner/output/beans (added)
• core/src/test/java/org/eobjects/datacleaner/output/beans/CreateExcelSpreadsheetAnalyzerTest.java (added)
• extensions/network-tools/src/main/java/org/eobjects/datacleaner/extension/networktools/NetworkToolsCategory.java (modified) (1 diff)
• pom.xml (modified) (1 diff)

DataCleaner/trunk/core/src/main/java/org/eobjects/datacleaner/output/beans/CreateExcelSpreadsheetAnalyzer.java

@@ -28 +28 @@
 import org.eobjects.analyzer.beans.api.Description;
 import org.eobjects.analyzer.beans.api.FileProperty;
+import org.eobjects.analyzer.beans.api.Validate;
 import org.eobjects.analyzer.beans.api.FileProperty.FileAccessMode;
 import org.eobjects.analyzer.beans.writers.WriteDataCategory;
@@ -52 +53 @@
         @Configured
         String sheetName;
+
+        @Validate
+        public void validate() {
+                if (sheetName.indexOf(".") != -1) {
+                        throw new IllegalStateException("Sheet name cannot contain dots (.)");
+                }
+        }
 
         @Override

DataCleaner/trunk/core/src/main/java/org/eobjects/datacleaner/widgets/properties/PropertyWidgetFactory.java

@@ -195 +195 @@
         }
 
+        /**
+         * Invoked whenever a configured property within this widget factory is
+         * changed.
+         */
         public void onConfigurationChanged() {
                 Collection<PropertyWidget<?>> widgets = getWidgets();

DataCleaner/trunk/extensions/network-tools/src/main/java/org/eobjects/datacleaner/extension/networktools/NetworkToolsCategory.java

@@ -24 +24 @@
 public class NetworkToolsCategory extends AbstractComponentCategory {
 
+    private static final long serialVersionUID = 1L;
+
 }

DataCleaner/trunk/pom.xml

@@ -4 +4 @@
                 <sshwagon.version>1.0-beta-7</sshwagon.version>
                 <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-                <analyzerbeans.version>0.10</analyzerbeans.version>
+                <analyzerbeans.version>0.11-SNAPSHOT</analyzerbeans.version>
         </properties>
         <parent>