Changeset 3112

Timestamp:

02/02/12 09:44:11 (4 months ago)

Author:

ankitk

Message:

Proper Exception handling.

Location:

AnalyzerBeans/trunk/components/json/src/main/java/org/eobjects/analyzer/beans

Files:

• ExtractJsonValuesTransformer.java (modified) (2 diffs)
• JsonCreatorTransformer.java (modified) (1 diff)

AnalyzerBeans/trunk/components/json/src/main/java/org/eobjects/analyzer/beans/ExtractJsonValuesTransformer.java

@@ -36 +36 @@
 import org.eobjects.analyzer.data.InputRow;
 
-@TransformerBean("Extract values from JSON document")
+@TransformerBean("Parse JSON document")
 @Description("Extract values from a JSON document")
 public class ExtractJsonValuesTransformer implements
@@ -72 +72 @@
                         jsonMap = mapper.readValue(jsonString, Map.class);
                 } catch (JsonParseException e) {
-                        e.printStackTrace();
+                        throw new IllegalStateException("Exception while parsing Json.");
                 } catch (JsonMappingException e) {
-                        e.printStackTrace();
+                        throw new IllegalStateException("Exception while Json mapping.");
                 } catch (IOException e) {
-                        e.printStackTrace();
+                        throw new IllegalStateException("IOException while parsing Json.");
                 }
                 final Map<String, ?>[] result = new Map[] { jsonMap };
                 return result;
         }
-
 }

AnalyzerBeans/trunk/components/json/src/main/java/org/eobjects/analyzer/beans/JsonCreatorTransformer.java

@@ -81 +81 @@
                         json = mapper.writeValueAsString(map);
                 } catch (JsonGenerationException e) {
-                        e.printStackTrace();
+                        throw new IllegalStateException("Exception while generating Json.");
                 } catch (JsonMappingException e) {
-                        e.printStackTrace();
+                        throw new IllegalStateException("Exception while Json mapping.");
                 } catch (IOException e) {
-                        e.printStackTrace();
+                        throw new IllegalStateException("IOException while Json mapping.");
                 }
                 return new String[] { json };